Only perform ref checks on components with stable refs. #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
faster-ci-checks
branch
3 times, most recently
from
ca702ec
to
0329939
Compare
peternied
reviewed
Jan 12, 2022
dblock
force-pushed
the
faster-ci-checks
branch
from
0329939
to
b5d1596
Compare
I considered it, but it felt like hidden logic/functionality. |
|
Other considerations:
|
These are good ideas, but why are they better than removing useless checks? |
|
Hmm, why keep around these manifests at all, why not delete them? |
So we can rebuild previous versions if needed/for reference. It's like keeping old source code. |
peternied
approved these changes
Jan 13, 2022
dblock
requested review from
peterzhuamazon,
a team,
gaiksaya and
abhinavGupta16
|
Given that JCenter is now gone we also need to do this (or something like this) for manifests such as 1.1.1. |
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
faster-ci-checks
branch
from
b5d1596
to
5ea579f
Compare
tianleh
approved these changes
Jan 18, 2022
peterzhuamazon
pushed a commit
to peterzhuamazon/opensearch-build
that referenced
this pull request
Feb 16, 2022
…roject#1455) Signed-off-by: dblock <dblock@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@amazon.com
Description
The manifest checks will continue taking longer and longer because we keep shipping releases. As of now, the 31 checks in https://github.com/opensearch-project/opensearch-build/actions/runs/1685288124 took 14m. It's not bad because the checks are parallelized.
We have suggested in #1335 to skip checking manifests for already released versions, but this PR proposes a better solution.
Issues Resolved
Closes #1335.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.