Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in common-utils build scripts #1793

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Mar 21, 2022

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Fix typo in common-utils build scripts

Issues Resolved

Part of #1624
#1790

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #1793 (cbef09d) into main (4ada5c4) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1793      +/-   ##
============================================
- Coverage     94.48%   94.35%   -0.14%     
  Complexity       18       18              
============================================
  Files           173      173              
  Lines          3611     3611              
  Branches         27       27              
============================================
- Hits           3412     3407       -5     
- Misses          195      200       +5     
  Partials          4        4              
Impacted Files Coverage Δ
src/system/temporary_directory.py 83.87% <0.00%> (-12.91%) ⬇️
src/system/os.py 92.30% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ada5c4...cbef09d. Read the comment docs.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@peterzhuamazon peterzhuamazon merged commit 36e6bf3 into opensearch-project:main Mar 22, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-cu-qualifier-fix branch March 22, 2022 00:00
@dblock
Copy link
Member

dblock commented Mar 22, 2022

Ouch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OpenSearch-2.0.0 snapshot build is failing due to common-utils
6 participants