Add qualifier support for docker build task #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
This was referenced Mar 29, 2022
gaiksaya
reviewed
Mar 29, 2022
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
gaiksaya
reviewed
Mar 29, 2022
tests/jenkins/jobs/BuildDockerImage_Jenkinsfile_builds_both.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
dblock
reviewed
Mar 30, 2022
|
|
||
| if (build_qualifier != null && build_qualifier != 'null') { | ||
| build_qualifier = "-" + build_qualifier | ||
| } |
There was a problem hiding this comment.
I should just default build_qualifier to null and check inputmanifest.build.qualifier.
Will change in a later improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add qualifier support for docker build task
Example: https://hub.docker.com/r/opensearchstaging/opensearch/tags?page=1&name=2.0.0-alpha1
Issues Resolved
Part of #1632
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.