Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new data.search.usageTelemetry.enabled to opensearch_dashboards_vars #1931

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

Flyingliuhub
Copy link
Member

Signed-off-by: Tao liu liutaoaz@amazon.com

Description

Adds new data.search.usageTelemetry.enabled to opensearch_dashboards_vars.
data.search.usageTelemetry.enabled will be used for controlling the search's usageTelemetry.
This is related with PR opensearch-project/OpenSearch-Dashboards#1427.

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tao liu <liutaoaz@amazon.com>
@Flyingliuhub Flyingliuhub requested a review from a team as a code owner April 7, 2022 17:43
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #1931 (5aaa542) into main (e97b1c9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1931   +/-   ##
=========================================
  Coverage     94.60%   94.60%           
  Complexity       20       20           
=========================================
  Files           178      178           
  Lines          3633     3633           
  Branches         27       27           
=========================================
  Hits           3437     3437           
  Misses          192      192           
  Partials          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97b1c9...5aaa542. Read the comment docs.

Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block this as 1.3.1 dashboards is in release.

@Flyingliuhub
Copy link
Member Author

Block this as 1.3.1 dashboards is in release.

we are targeting 2.0.0, I can't change the labels as no permission, can you mark the label for 2.0.0 or provide permission for me. Thanks

@peterzhuamazon
Copy link
Member

Block this as 1.3.1 dashboards is in release.

we are targeting 2.0.0, I can't change the labels as no permission, can you mark the label for 2.0.0 or provide permission for me. Thanks

Added tags.

@peterzhuamazon peterzhuamazon merged commit eb1fafd into opensearch-project:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants