Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root #1990

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Apr 19, 2022

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@kavilla
Copy link
Member

kavilla commented Apr 19, 2022

BWC tests should work it's just failing due to security plugin.

@bbarani
Copy link
Member

bbarani commented Apr 19, 2022

BWC tests should work it's just failing due to security plugin.

@kavilla Are you taking about OpenSearch dashboards?

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon changed the title Remove BWC test for now as BWC framework does not run correctly Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root Apr 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1990 (a20211c) into main (7c732e9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1990   +/-   ##
=========================================
  Coverage     94.41%   94.41%           
  Complexity       22       22           
=========================================
  Files           187      187           
  Lines          3739     3739           
  Branches         29       29           
=========================================
  Hits           3530     3530           
  Misses          203      203           
  Partials          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c732e9...a20211c. Read the comment docs.

@peterzhuamazon
Copy link
Member Author

Merge it now, we can add back later on.

@peterzhuamazon peterzhuamazon merged commit 43d52fa into opensearch-project:main Apr 20, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-rpm-bwc-disable branch April 20, 2022 19:25
@kavilla
Copy link
Member

kavilla commented Apr 20, 2022

Merge it now, we can add back later on.

BWC test were running for OpenSearch Dashboards tar distributions they were actually catching some issues that should be followed up. I guess my question instead of full out removing it from everything we remove the BWC tests from the test manifest being called but otherwise this will just add a few minutes to test run to keep this in it was just show a "failed" notification versus removing this completely. Seems much more is lost here than gained.

peterzhuamazon added a commit to peterzhuamazon/opensearch-build that referenced this pull request Apr 20, 2022
…ly as well as rpm integTest as it requires root (opensearch-project#1990)"

This reverts commit 43d52fa.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon added a commit to peterzhuamazon/opensearch-build that referenced this pull request Apr 20, 2022
…able tar bwc test for 2.0.0

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon added a commit that referenced this pull request Apr 20, 2022
…for 2.0.0 (#2009)

* Revert "Remove BWC test for now as BWC framework does not run correctly as well as rpm integTest as it requires root (#1990)"

This reverts commit 43d52fa.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Revert #1990 and remove rpm integ/bwc test, and disable tar bwc test for 2.0.0

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add back debug related output vars

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants