Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the build repo is pulled in docker-build stage #2060

Merged

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Make sure the build repo is pulled in docker-build stage.
Directly use agent node will have consequences where git repo is not pulled.
Running on docker container will force the pull every time.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #2060 (02c1262) into main (ec6c37c) will increase coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2060      +/-   ##
============================================
+ Coverage     94.10%   94.23%   +0.12%     
  Complexity       25       25              
============================================
  Files           198      198              
  Lines          3902     3902              
  Branches         29       29              
============================================
+ Hits           3672     3677       +5     
+ Misses          224      219       -5     
  Partials          6        6              
Impacted Files Coverage Δ
src/system/os.py 100.00% <0.00%> (+6.25%) ⬆️
src/system/temporary_directory.py 96.77% <0.00%> (+12.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6c37c...02c1262. Read the comment docs.

@peterzhuamazon
Copy link
Member Author

See OS build 2626 vs 2629 for docker build trigger comparison.

@peterzhuamazon peterzhuamazon merged commit 2fe7723 into opensearch-project:main Apr 29, 2022
@peterzhuamazon peterzhuamazon deleted the opensearch-docker-fix branch April 29, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants