Temporary comment out the macos build section snapshots #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2442 +/- ##
============================================
+ Coverage 94.63% 94.83% +0.20%
============================================
Files 211 157 -54
Lines 4322 4144 -178
Branches 29 19 -10
============================================
- Hits 4090 3930 -160
+ Misses 226 214 -12
+ Partials 6 0 -6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@peterzhuamazon we already have the way include the platform, can we please use this |
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
prudhvigodithi
approved these changes
Aug 9, 2022
I was thinking it is also building plugins as a bundle but apparently only pushing core since it is just a snapshot. Thanks. |
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Zhu zhujiaxi@amazon.com
Description
Temporary comment out the macos build section snapshots
Issues Resolved
opensearch-project/alerting#516
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.