Override browser default from chromium to electron as Cypress 9.5.4 does not run with chromium 114+ #4383
Conversation
…oes not run with chromium 114+ Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
added
bug
peterzhuamazon
requested review from
dblock,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4383 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 190 190
Lines 6197 6197
=======================================
Hits 5661 5661
Misses 536 536 ☔ View full report in Codecov by Sentry. |
|
Any reason to update |
|
Hi @tianleh v4 is pointed to the latest version (which is 4.3), and v4.2 is just 4.2 here. |
| "tar": "-u 1000 -e BROWSER_PATH=electron", | ||
| "rpm": "--entrypoint=/usr/lib/systemd/systemd -u root --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:rw --cgroupns=host -e BROWSER_PATH=electron", | ||
| "deb": "--entrypoint=/usr/lib/systemd/systemd -u root --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:rw --cgroupns=host -e BROWSER_PATH=electron", | ||
| "zip": "-u ContainerAdministrator -e BROWSER_PATH=electron", |
There was a problem hiding this comment.
Where is this variable resolved? Sorry if I missed previous PR related to this change
There was a problem hiding this comment.
We can either define it here or change the default of FTrepo.
In talk with the repo maintainer now.
There was a problem hiding this comment.
Looks good to me to use an env variable.
|
Have discussed with @tianleh and since integtest.sh is only for open source, we can safely change it to electron as default. We will run the above changes in Jenkins for a while before switching the ftrepo settings. Thanks. |
Description
Override browser default from chromium to electron as Cypress 9.5.4 does not run with chromium 114+
Issues Resolved
Closes #4241
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.