Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integtest input arguments changes and integration with s3 #456

Merged
merged 7 commits into from
Sep 15, 2021

Conversation

setiah
Copy link
Contributor

@setiah setiah commented Sep 10, 2021

Description

This PR has 2 main changes -

  1. Make the input arguments streamlined with what Jenkins pipeline(and the build workflow) would provide to the integ test job.
  2. Read artifacts and manifests for a given build from S3 bucket.

Issues Resolved

#457

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Himanshu Setia added 2 commits September 10, 2021 15:47
…s from s3

Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #456 (fda385e) into main (9a5843f) will increase coverage by 0.34%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   68.97%   69.31%   +0.34%     
==========================================
  Files          58       58              
  Lines        1473     1509      +36     
==========================================
+ Hits         1016     1046      +30     
- Misses        457      463       +6     
Impacted Files Coverage Δ
bundle-workflow/src/manifests/test_manifest.py 0.00% <0.00%> (ø)
bundle-workflow/src/run_integ_test.py 0.00% <0.00%> (ø)
...w/src/test_workflow/integ_test/integ_test_suite.py 0.00% <0.00%> (ø)
...src/test_workflow/integ_test/local_test_cluster.py 0.00% <0.00%> (ø)
bundle-workflow/src/manifests/build_manifest.py 100.00% <100.00%> (ø)
bundle-workflow/src/manifests/bundle_manifest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a5843f...fda385e. Read the comment docs.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reliance on current directory and the leftover temp file should def be fixed before merging.

bundle-workflow/README.md Outdated Show resolved Hide resolved
bundle-workflow/README.md Outdated Show resolved Hide resolved
bundle-workflow/src/run_integ_test.py Outdated Show resolved Hide resolved
bundle-workflow/src/run_integ_test.py Outdated Show resolved Hide resolved
bundle-workflow/README.md Outdated Show resolved Hide resolved
Himanshu Setia added 2 commits September 13, 2021 21:16
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple that I think are must have's.

bundle-workflow/README.md Outdated Show resolved Hide resolved
bundle-workflow/src/manifests/build_manifest.py Outdated Show resolved Hide resolved
Signed-off-by: Himanshu Setia <setiah@amazon.com>
dblock
dblock previously approved these changes Sep 15, 2021
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly should have's but nothing blocking.

bundle-workflow/README.md Outdated Show resolved Hide resolved
bundle-workflow/scripts/default/integtest.sh Outdated Show resolved Hide resolved
bundle-workflow/src/run_integ_test.py Outdated Show resolved Hide resolved
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @setiah for the change.
Changes look good to me!

@setiah setiah merged commit 9032bdc into opensearch-project:main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants