-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integtest input arguments changes and integration with s3 #456
Conversation
…s from s3 Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #456 +/- ##
==========================================
+ Coverage 68.97% 69.31% +0.34%
==========================================
Files 58 58
Lines 1473 1509 +36
==========================================
+ Hits 1016 1046 +30
- Misses 457 463 +6
Continue to review full report at Codecov.
|
bundle-workflow/src/test_workflow/utils/build_manifest_provider.py
Outdated
Show resolved
Hide resolved
bundle-workflow/src/test_workflow/utils/bundle_manifest_provider.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reliance on current directory and the leftover temp file should def be fixed before merging.
bundle-workflow/src/test_workflow/utils/build_manifest_provider.py
Outdated
Show resolved
Hide resolved
bundle-workflow/src/test_workflow/utils/build_manifest_provider.py
Outdated
Show resolved
Hide resolved
bundle-workflow/src/test_workflow/utils/build_manifest_provider.py
Outdated
Show resolved
Hide resolved
bundle-workflow/src/test_workflow/utils/bundle_manifest_provider.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple that I think are must have's.
bundle-workflow/src/test_workflow/integ_test/integ_test_suite.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Himanshu Setia <setiah@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly should have's but nothing blocking.
bundle-workflow/src/test_workflow/integ_test/integ_test_suite.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @setiah for the change.
Changes look good to me!
Description
This PR has 2 main changes -
Issues Resolved
#457
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.