Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeJS Upgrade] Correct chromium path found in Windows #295

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented May 25, 2023

Description

[NodeJS Upgrade] Correct chromium path found in Windows

Issues Resolved

opensearch-project/opensearch-build#3434
opensearch-project/opensearch-build#1563

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon merged commit 83a1f98 into opensearch-project:main May 25, 2023
@peterzhuamazon peterzhuamazon deleted the windows_chromium_fix2 branch May 25, 2023 21:49
peterzhuamazon added a commit to peterzhuamazon/opensearch-ci that referenced this pull request May 25, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon added a commit that referenced this pull request May 25, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon changed the title Correct chromium path found in Windows [NodeJS Upgrade] Correct chromium path found in Windows Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants