Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fetch Migration] Include index aliases in metadata migration #429

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

kartg
Copy link
Member

@kartg kartg commented Nov 14, 2023

Description

Small update to the metadata migration step of Fetch Migration to include index aliases during metadata migration. This PR also includes unit test updates, as well as a minor fix to the Data Prepper pipeline template file used by the CDK to remove an invalid flag (Data Prepper does not require explicit configuration to toggle TLS).

  • Category: Enhancement + Bug fix

Testing

$ python -m coverage report --omit "*/tests/*"
Name                           Stmts   Miss  Cover
--------------------------------------------------
endpoint_info.py                  24      0   100%
endpoint_utils.py                107      1    99%
fetch_orchestrator.py             70      0   100%
fetch_orchestrator_params.py      22      0   100%
index_diff.py                     20      0   100%
index_doc_count.py                 5      0   100%
index_operations.py               53      0   100%
metadata_migration.py             59      0   100%
metadata_migration_params.py       7      0   100%
metadata_migration_result.py       5      0   100%
migration_monitor.py              89      0   100%
migration_monitor_params.py        6      0   100%
progress_metrics.py               91      0   100%
utils.py                          13      0   100%
--------------------------------------------------
TOTAL                            571      1    99%

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bce4aed) 62.87% compared to head (829cb8f) 63.16%.
Report is 41 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #429      +/-   ##
============================================
+ Coverage     62.87%   63.16%   +0.29%     
- Complexity      865      873       +8     
============================================
  Files            99      100       +1     
  Lines          4339     4341       +2     
  Branches        404      410       +6     
============================================
+ Hits           2728     2742      +14     
+ Misses         1341     1328      -13     
- Partials        270      271       +1     
Flag Coverage Δ
unittests 63.16% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sumobrian sumobrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kartg kartg merged commit df78bb0 into opensearch-project:main Nov 15, 2023
8 checks passed
@kartg kartg deleted the fetch-index-alias branch November 15, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants