Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design document for the Capture Proxy and Replayer. #964

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

gregschohn
Copy link
Collaborator

Description

  • Category Documentation

Issues Resolved

part of https://opensearch.atlassian.net/browse/MIGRATIONS-1986

Testing

No testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.69%. Comparing base (f7d6fb6) to head (6fc74c0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #964   +/-   ##
=========================================
  Coverage     80.69%   80.69%           
  Complexity     2691     2691           
=========================================
  Files           398      398           
  Lines         15317    15317           
  Branches        956      956           
=========================================
  Hits          12360    12360           
  Misses         2385     2385           
  Partials        572      572           
Flag Coverage Δ
gradle-test 76.65% <ø> (ø)
python-test 92.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gregschohn gregschohn changed the title Publishing a design document for the capture proxy and replayer. Design document for the Capture Proxy and Replayer. Sep 17, 2024
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you need a detailed review of this content? It seems like a majority of of is coming from the aws solution document and so this is more about moving the doc rather than fine-grain review.

@@ -0,0 +1,271 @@
# TrafficCapture and Replay
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TrafficCapture and Replay
# Traffic Capture and Replay Design

I think this document might be better classified as an overview instead of a design.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the partial change - since there's a question of whether its an Overview or Design, I'll leave the filename speak for itself (the ALB splitter doc doesn't mention what kind of doc it is within the title, so I didn't bother w/ that for consistency).

Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
@gregschohn gregschohn merged commit 5fd341d into opensearch-project:main Sep 19, 2024
15 checks passed
@gregschohn gregschohn deleted the CaptureReplayDesignDoc branch September 20, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants