-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design document for the Capture Proxy and Replayer. #964
Design document for the Capture Proxy and Replayer. #964
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
=========================================
Coverage 80.69% 80.69%
Complexity 2691 2691
=========================================
Files 398 398
Lines 15317 15317
Branches 956 956
=========================================
Hits 12360 12360
Misses 2385 2385
Partials 572 572
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you need a detailed review of this content? It seems like a majority of of is coming from the aws solution document and so this is more about moving the doc rather than fine-grain review.
@@ -0,0 +1,271 @@ | |||
# TrafficCapture and Replay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# TrafficCapture and Replay | |
# Traffic Capture and Replay Design |
I think this document might be better classified as an overview instead of a design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the partial change - since there's a question of whether its an Overview or Design, I'll leave the filename speak for itself (the ALB splitter doc doesn't mention what kind of doc it is within the title, so I didn't bother w/ that for consistency).
Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
2bc452b
to
dd4773b
Compare
Description
Issues Resolved
part of https://opensearch.atlassian.net/browse/MIGRATIONS-1986
Testing
No testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.