Fixed more RFS version* SonarQube #982
Open
+55
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Helma <chelma+github@amazon.com>
chelma
requested review from
AndreKurait,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn,
peternied and
sumobrian
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
============================================
+ Coverage 78.98% 79.01% +0.02%
- Complexity 2723 2727 +4
============================================
Files 375 375
Lines 13869 13871 +2
Branches 970 968 -2
============================================
+ Hits 10955 10960 +5
+ Misses 2340 2338 -2
+ Partials 574 573 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peternied
approved these changes
Sep 19, 2024
Comment on lines
-149
to
-150
| var alreadyExists = templateType.alreadyExistsCheck.templateAlreadyExists(client, templateName); | ||
| if (!alreadyExists) { |
There was a problem hiding this comment.
Another rule that IMO makes the code harder to read, but oh well. We can review the rules in depth later
There was a problem hiding this comment.
Yeah, I'm not crazy about a fair number of them. I suspect it's a feature, not a bug, that disabling rules is so hard though.
Signed-off-by: Chris Helma <chelma+github@amazon.com>
peternied
approved these changes
Sep 20, 2024
Signed-off-by: Chris Helma <chelma+github@amazon.com>
Signed-off-by: Chris Helma <chelma+github@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Testing
All the local tests
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.