Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix invalid character in default-values #993

Merged

Conversation

lewijacn
Copy link
Collaborator

@lewijacn lewijacn commented Sep 20, 2024

Description

Bug fix for invalid default-values

SyntaxError: /home/ec2-user/workspace/rfs-default-e2e-test/deployment/cdk/opensearch-service-migration/default-values.json: Unexpected token } in JSON at position 482
    at parse (<anonymous>)
    at Object.Module._extensions..json (node:internal/modules/cjs/loader:1440:39)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:177:18)
    at Object.<anonymous> (/home/ec2-user/workspace/rfs-default-e2e-test/deployment/cdk/opensearch-service-migration/lib/stack-composer.ts:6:1)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at Module.m._compile (/home/ec2-user/workspace/rfs-default-e2e-test/deployment/cdk/opensearch-service-migration/node_modules/ts-node/src/index.ts:1618:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.92%. Comparing base (4ad0443) to head (31f62b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #993   +/-   ##
=========================================
  Coverage     78.92%   78.92%           
  Complexity     2723     2723           
=========================================
  Files           374      374           
  Lines         13809    13809           
  Branches        970      970           
=========================================
  Hits          10899    10899           
  Misses         2336     2336           
  Partials        574      574           
Flag Coverage Δ
gradle-test 76.80% <ø> (ø)
python-test 89.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait merged commit b1ce98b into opensearch-project:main Sep 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants