Improve opensearch.pluginzip docs.
#153
Conversation
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
|
Hey @reta pushed the latest commit with your suggested changes. |
BUILDING.md
Outdated
| ```./gradlew publishPluginZipPublicationToZipStagingRepository -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT -Dbuild.version_qualifier=$QUALIFIER``` | ||
|
|
||
| Note: The gradle assemble task `./gradlew assemble` should be called first before calling `publishPluginZipPublicationToZipStagingRepository`, as zip file need to be generated first before publishing. | ||
| Note: The gradle assemble task `./gradlew assemble` should be called first before calling `publishPluginZipPublicationToZipStagingRepository`, as zip file need to be generated before publishing. |
There was a problem hiding this comment.
Not sure if plugins support ./gradle assemble, i know few plugins use ./gradle build[1]
There was a problem hiding this comment.
AD plugin does support ./gradlew assemble
There was a problem hiding this comment.
Thanks for the inputs @saratvemulapalli and @ylwu-amzn, the idea to mention the zip has be available (either by calling assemble or build) before publishing, let me rephrase the following way and let me know if this is good to go with.
Note: The gradle task responsible to generate the distribution zip should be called first before executing publishPluginZipPublicationToZipStagingRepository, as the zip file needs to be generated before publishing.
There was a problem hiding this comment.
Pushed the change in my latest commit.
@saratvemulapalli @ylwu-amzn
Signed-off-by: pgodithi <pgodithi@amazon.com>
prudhvigodithi
dismissed stale reviews from saratvemulapalli, gaiksaya, and reta
via
a9de3c7
saratvemulapalli
added
the
documentation
Signed-off-by: pgodithi pgodithi@amazon.com
Description
Improve
opensearch.pluginzipdocs, to add more details, purpose and boundaries of usage.Issues Resolved
opensearch-project/OpenSearch#3692
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.