feat: allow passing trust_env to aiohttp.ClientSession
#438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeloliverx
requested review from
VachaShah,
dblock,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
michaeloliverx
force-pushed
the
michaeloliverx/issue368
branch
5 times, most recently
from
8bd5d88
to
104b9de
Compare
Codecov Report
@@ Coverage Diff @@
## main #438 +/- ##
=======================================
Coverage 71.48% 71.49%
=======================================
Files 81 81
Lines 7667 7668 +1
=======================================
+ Hits 5481 5482 +1
Misses 2186 2186
|
dblock
previously approved these changes
Jul 18, 2023
michaeloliverx
force-pushed
the
michaeloliverx/issue368
branch
from
104b9de
to
cbb985f
Compare
Fixes opensearch-project#368 Signed-off-by: Michael Oliver <michael@michaeloliver.dev>
michaeloliverx
force-pushed
the
michaeloliverx/issue368
branch
from
cbb985f
to
b8df821
Compare
dblock
approved these changes
Jul 19, 2023
This was referenced Jul 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I initially opened issue #368 for this feature, there have been a few PRs but none have gotten over the line by adding tests so I'll give it a try.
Issues Resolved
Fixes #368 #372 #370
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.