Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add override for code generator to change indices.put_alias argument order #804

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Add override for code generator to change indices.put_alias argument order #804

merged 3 commits into from
Aug 22, 2024
+147 −115

Commits on Aug 22, 2024

  1. Add currently-failing test to validate the original argument order 

    Signed-off-by: Jeppe Fihl-Pearson <jeppe@memrise.com>
    @Tenzer
    Tenzer committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    b0dd9c8 View commit details
    Browse the repository at this point in the history

  2. Add workaround for breaking API change inadvertently added in v2.7.0 

    Signed-off-by: Jeppe Fihl-Pearson <jeppe@memrise.com>
    @Tenzer
    Tenzer committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    eec018b View commit details
    Browse the repository at this point in the history

  3. Generate new version of the client code with the correct argument order 

    Signed-off-by: Jeppe Fihl-Pearson <jeppe@memrise.com>
    @Tenzer
    Tenzer committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    4be23a6 View commit details
    Browse the repository at this point in the history