-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bulk guide #155
Add bulk guide #155
Conversation
Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>
Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sayuree, thanks for contributing!
Overall the guide looks good, just some minor code issues.
It would also be great if you could create a matching example file like this one: https://github.com/opensearch-project/opensearch-rs/blob/main/opensearch/examples/index_template.rs
It's very useful for making sure the code is correct and compiles.
Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>
Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>
Signed-off-by: sabina.zaripova <sabina.zaripova@nu.edu.kz>
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 65.43% 73.62% +8.19%
==========================================
Files 315 398 +83
Lines 52415 62810 +10395
==========================================
+ Hits 34296 46246 +11950
+ Misses 18119 16564 -1555
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Add Bulk guide
Issues Resolved
closes #144
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.