Refactor mock HTTP server tests #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 74.00% 74.00%
=======================================
Files 403 403
Lines 64198 64198
=======================================
Hits 47508 47508
Misses 16690 16690
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Xtansia
force-pushed
the
refactor/tests
branch
from
551f948
to
c7da884
Compare
reta
reviewed
Dec 11, 2023
opensearch/tests/common/server.rs
Outdated
| } | ||
|
|
||
| pub fn start() -> anyhow::Result<MockServer> { | ||
| MockServerBuilder::default().start() |
There was a problem hiding this comment.
Suggested change
| MockServerBuilder::default().start() | |
| builder().start() |
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Xtansia
force-pushed
the
refactor/tests
branch
from
c7da884
to
8691aea
Compare
reta
approved these changes
Dec 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Refactor mock http server tests Signed-off-by: Thomas Farr <tsfarr@amazon.com> * de-dup code Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 1035d4e)
Xtansia
added a commit
that referenced
this pull request
Dec 12, 2023
* Refactor mock http server tests Signed-off-by: Thomas Farr <tsfarr@amazon.com> * de-dup code Signed-off-by: Thomas Farr <tsfarr@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> (cherry picked from commit 1035d4e) Co-authored-by: Thomas Farr <tsfarr@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the mock HTTP server tests to simplify the test code.
Splitting up parts of #132
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.