Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.apache.lucene:lucene-core to v9.5.0 #388

Closed

Conversation

mend-for-github-com[bot]
Copy link
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.apache.lucene:lucene-core (source) 9.4.2 -> 9.5.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

dbwiddis
dbwiddis previously approved these changes Jan 30, 2023
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like a system where we stay in sync with OpenSearch core version. @saratvemulapalli @ryanbogan is dependency version compatibility part of your versioning work/

@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/luceneversion branch 2 times, most recently from 76c9fa0 to b0bec61 Compare January 30, 2023 18:58
@saratvemulapalli
Copy link
Member

I would really like a system where we stay in sync with OpenSearch core version. @saratvemulapalli @ryanbogan is dependency version compatibility part of your versioning work/

Thats a good point. Its not part of #337. But this is a solved problem for plugins. We could use gradle[1]

[1] https://docs.gradle.org/current/userguide/platforms.html#sub:central-declaration-of-dependencies

@dbwiddis dbwiddis self-requested a review January 30, 2023 20:09
dbwiddis
dbwiddis previously approved these changes Jan 30, 2023
@dbwiddis
Copy link
Member

I would really like a system where we stay in sync with OpenSearch core version. @saratvemulapalli @ryanbogan is dependency version compatibility part of your versioning work/

Thats a good point. Its not part of #337. But this is a solved problem for plugins. We could use gradle[1]

[1] https://docs.gradle.org/current/userguide/platforms.html#sub:central-declaration-of-dependencies

See opensearch-project/opensearch-build#2689

@saratvemulapalli
Copy link
Member

@dbwiddis taking a look at this: I dont think SDK has any dependencies on lucene at this point[1].
I can send out a change to remove it. I've tested it locally.

[1] https://github.com/search?q=repo%3Aopensearch-project%2Fopensearch-sdk-java%20org.apache.lucene&type=code

@dbwiddis
Copy link
Member

Might be needed for AnalysisPlugin (AnalysisExtension) migration.

@dbwiddis
Copy link
Member

So yes it's definitely going to be needed for AnalysisExtension to migrate AnalysisPlugin.

I'm ok with removing it now, if the long term plan is to add it back via a dependency catalog per your suggestion.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Merging #388 (23f7414) into main (514f796) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main     #388   +/-   ##
=========================================
  Coverage     62.32%   62.32%           
  Complexity      159      159           
=========================================
  Files            30       30           
  Lines           730      730           
  Branches         20       20           
=========================================
  Hits            455      455           
  Misses          266      266           
  Partials          9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/luceneversion branch 6 times, most recently from 1db555e to 38b98e6 Compare February 5, 2023 17:16
dbwiddis
dbwiddis previously approved these changes Feb 5, 2023
@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/luceneversion branch 9 times, most recently from b091d49 to 23f7414 Compare February 13, 2023 21:06
@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/luceneversion branch 2 times, most recently from 95f7c34 to 658540b Compare February 17, 2023 00:44
@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/luceneversion branch from 658540b to 04cfa20 Compare February 20, 2023 18:50
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
@mend-for-github-com mend-for-github-com bot force-pushed the whitesource-remediate/luceneversion branch from 04cfa20 to 72cf163 Compare February 20, 2023 19:52
@owaiskazi19
Copy link
Member

We have removed lucene here: #465. Closing this PR.

@mend-for-github-com mend-for-github-com bot deleted the whitesource-remediate/luceneversion branch February 20, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants