Refactor Flint index refresh mode #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen
commented
Jan 18, 2024
Comment on lines
-346
to
-347
| case FULL if isIncrementalRefreshing(indexName) => | ||
| throw new IllegalStateException( | ||
| s"Index $indexName is incremental refreshing and cannot be manual refreshed") |
There was a problem hiding this comment.
Because refresh mode is decided by index options in refresh index API internally, this case is impossible now.
dai-chen
requested review from
rupal-bq,
vamsi-amazon,
penghuo,
anirudha,
kaituo and
YANG-DB
as code owners
Signed-off-by: Chen Dai <daichen@amazon.com>
|
Merged from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR primarily removes the
refreshModein therefreshIndex()API, which is internally used by the SQL layer. This change serves as a prerequisite for follow-up changes that introduce Manual-Incremental refresh mode for #195.Before the change
Currently, Flint SQL layer always pass the following mode to refresh index API layer:
INCREMENTALmode ifCREATE INDEX ... WITH (auto_refresh=true)FULLmode ifREFRESH INDEXstatementAfter the change
The meaning of refresh mode
The revision clarifies that the refresh mode is inherently a characteristic of the Flint index upon creation, rather than something that can be specified later through either the
refreshIndexAPI or theREFRESHstatement. In other words, therefreshIndexAPI will autonomously determine the mode by reading the Flint index options.Refresh statement behavior
The refresh statement behavior remains unchanged:
refreshingmode (a new IT has been added to verify this).Issues Resolved
#100
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.