-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BloomFilter query pushdown optimization #271
Merged
dai-chen
merged 5 commits into
opensearch-project:main
from
dai-chen:implement-bloom-filter-query-pushdown
Mar 11, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
72a4f32
Add pushdown optimization by painless script
dai-chen 91a0ece
Update UT and indent script code
dai-chen 9888af8
Minor refactor painless script
dai-chen 0d60837
Fix broken IT
dai-chen 8c93f63
Merge branch 'main' into implement-bloom-filter-query-pushdown
dai-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
109 changes: 109 additions & 0 deletions
109
flint-spark-integration/src/main/resources/bloom_filter_query.script
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| int hashLong(long input, int seed) { | ||
| int low = (int) input; | ||
| int high = (int) (input >>> 32); | ||
| int k1 = mixK1(low); | ||
| int h1 = mixH1(seed, k1); | ||
| k1 = mixK1(high); | ||
| h1 = mixH1(h1, k1); | ||
| return fmix(h1, 8); | ||
| } | ||
|
|
||
| int mixK1(int k1) { | ||
| k1 *= 0xcc9e2d51L; | ||
| k1 = Integer.rotateLeft(k1, 15); | ||
| k1 *= 0x1b873593L; | ||
| return k1; | ||
| } | ||
|
|
||
| int mixH1(int h1, int k1) { | ||
| h1 ^= k1; | ||
| h1 = Integer.rotateLeft(h1, 13); | ||
| h1 = h1 * 5 + (int) 0xe6546b64L; | ||
| return h1; | ||
| } | ||
|
|
||
| int fmix(int h1, int length) { | ||
| h1 ^= length; | ||
| h1 ^= h1 >>> 16; | ||
| h1 *= 0x85ebca6bL; | ||
| h1 ^= h1 >>> 13; | ||
| h1 *= 0xc2b2ae35L; | ||
| h1 ^= h1 >>> 16; | ||
| return h1; | ||
| } | ||
|
|
||
| BytesRef bfBytes = doc[params.fieldName].value; | ||
| byte[] buf = bfBytes.bytes; | ||
| int pos = 0; | ||
| int count = buf.length; | ||
| int ch1 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| int ch2 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| int ch3 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| int ch4 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| int version = ((ch1 << 24) + (ch2 << 16) + (ch3 << 8) + (ch4 << 0)); | ||
| ch1 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| ch2 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| ch3 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| ch4 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| int numHashFunctions = ((ch1 << 24) + (ch2 << 16) + (ch3 << 8) + (ch4 << 0)); | ||
| ch1 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| ch2 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| ch3 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| ch4 = (pos < count) ? (buf[pos++] & (int) 0xffL) : -1; | ||
| int numWords = ((ch1 << 24) + (ch2 << 16) + (ch3 << 8) + (ch4 << 0)); | ||
|
|
||
| long[] data = new long[numWords]; | ||
| byte[] readBuffer = new byte[8]; | ||
| for (int i = 0; i < numWords; i++) { | ||
| int n = 0; | ||
| while (n < 8) { | ||
| int readCount; | ||
| int off = n; | ||
| int len = 8 - n; | ||
| if (pos >= count) { | ||
| readCount = -1; | ||
| } else { | ||
| int avail = count - pos; | ||
| if (len > avail) { | ||
| len = avail; | ||
| } | ||
| if (len <= 0) { | ||
| readCount = 0; | ||
| } else { | ||
| System.arraycopy(buf, pos, readBuffer, off, len); | ||
| pos += len; | ||
| readCount = len; | ||
| } | ||
| } | ||
| n += readCount; | ||
| } | ||
| data[i] = (((long) readBuffer[0] << 56) + | ||
| ((long) (readBuffer[1] & 255) << 48) + | ||
| ((long) (readBuffer[2] & 255) << 40) + | ||
| ((long) (readBuffer[3] & 255) << 32) + | ||
| ((long) (readBuffer[4] & 255) << 24) + | ||
| ((readBuffer[5] & 255) << 16) + | ||
| ((readBuffer[6] & 255) << 8) + | ||
| ((readBuffer[7] & 255) << 0)); | ||
| } | ||
|
|
||
| long bitCount = 0; | ||
| for (long word : data) { | ||
| bitCount += Long.bitCount(word); | ||
| } | ||
|
|
||
| long item = params.value; | ||
| int h1 = hashLong(item, 0); | ||
| int h2 = hashLong(item, h1); | ||
| long bitSize = (long) data.length * Long.SIZE; | ||
| for (int i = 1; i <= numHashFunctions; i++) { | ||
| int combinedHash = h1 + (i * h2); | ||
| if (combinedHash < 0) { | ||
| combinedHash = ~combinedHash; | ||
| } | ||
| long index = combinedHash % bitSize; | ||
| if ((data[(int) (index >>> 6)] & (1L << index)) == 0) { | ||
| return false; | ||
| } | ||
| } | ||
| return true; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably minify this removing spaces and changing variable names. That reduces readability. Not sure if we can add a step in final build before bundling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore if it is too much optimization and we are way below limits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I recall in C there is tool compress/obfuscate the code. Painless is not that popular that I'm not sure if any tool rather than do this manually. Will take another look. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since painless is mainly java, I just used this https://www.aspect-ratios.com/minify-java/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking of something at runtime when loading or sending to OpenSearch. Otherwise like you pointed out, it will result in code hard to maintain? Will make a note and address it if any issue found later. Thanks!