Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more filter push down in skipping strategy #7

Merged
merged 10 commits into from
Jul 28, 2023

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Jul 13, 2023

Description

  1. In each skipping strategy FlintSparkSkippingStrategy:
    a. Support more push down, especially support different expressions for MinMax
    b. Change Predicate to its parent Expression in trait to avoid type cast
  2. In query rewrite rule ApplyFlintSparkSkippingIndex:
    a. Add verification to only apply rule to single or conjunction expression
    b. Add missing UT (use queryIndex() for easy mock)
  3. Fix an assertion matcher bug in FlintSparkSkippingIndexITSuite

Issues Resolved

#2

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added the enhancement New feature or request label Jul 13, 2023
@dai-chen dai-chen self-assigned this Jul 13, 2023
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen changed the title Support more filter push down in each skipping strategy Support more filter push down in skipping strategy Jul 14, 2023
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review July 14, 2023 21:16
Signed-off-by: Chen Dai <daichen@amazon.com>
@penghuo penghuo merged commit f05dba9 into opensearch-project:main Jul 28, 2023
4 checks passed
@dai-chen dai-chen deleted the improve-filter-push-down branch July 31, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants