Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PA directories from plugins to root #168

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Apr 18, 2022

Signed-off-by: sruti1312 srutiparthiban@gmail.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
opensearch-project/performance-analyzer#188

Describe the solution you are proposing
Update PA directories from plugins to root

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #168 (374dd9b) into main (c020cc9) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #168      +/-   ##
============================================
+ Coverage     71.37%   71.42%   +0.04%     
+ Complexity     2937     2936       -1     
============================================
  Files           376      376              
  Lines         18765    18765              
  Branches       1445     1445              
============================================
+ Hits          13394    13402       +8     
+ Misses         4780     4772       -8     
  Partials        591      591              
Impacted Files Coverage Δ
...rch/performanceanalyzer/config/PluginSettings.java 28.74% <ø> (ø)
...nsearch/performanceanalyzer/rca/RcaController.java 79.29% <0.00%> (-1.77%) ⬇️
.../org/opensearch/performanceanalyzer/core/Util.java 70.83% <0.00%> (+8.33%) ⬆️
...nceanalyzer/rca/samplers/MetricsDBFileSampler.java 84.09% <0.00%> (+9.09%) ⬆️
...nalyzer/rca/net/handler/PublishRequestHandler.java 85.71% <0.00%> (+12.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c020cc9...374dd9b. Read the comment docs.

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
@sruti1312 sruti1312 merged commit 189f66d into main Apr 18, 2022
@sruti1312 sruti1312 deleted the feature/rename branch April 18, 2022 23:42
sruti1312 added a commit that referenced this pull request May 11, 2022
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
sruti1312 added a commit that referenced this pull request May 17, 2022
* Update folder names (#166)

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>

* Update PA directories from plugins to root (#168)

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>

* Update configFilePath location (#172)

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>

* Disable plugin if configFilePath is not present (#173)

Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants