Adds setting to enable/disable Thread Contention Monitoring #171
Conversation
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
============================================
+ Coverage 71.61% 71.77% +0.16%
- Complexity 355 367 +12
============================================
Files 44 44
Lines 2459 2519 +60
Branches 160 169 +9
============================================
+ Hits 1761 1808 +47
- Misses 591 598 +7
- Partials 107 113 +6
Continue to review full report at Codecov.
|
| try { | ||
| threadContentionMonitoringEnabledFromConf = readBooleanFromFile(filePath); | ||
| } catch (NoSuchFileException e) { | ||
| LOG.debug("Error reading Performance Analyzer state from Conf file", e); |
There was a problem hiding this comment.
Error reading thread contention monitoring state?
There was a problem hiding this comment.
@eirsep nit: I think this change was missed in the revision.
| if (shouldEnable | ||
| && !performanceAnalyzerController.isPerformanceAnalyzerEnabled()) { | ||
| return getChannelConsumerWithError( | ||
| "Error: PA not enabled. Enable PA before turning Batch Metrics on"); |
There was a problem hiding this comment.
nit: "Enable PA before turning thread contention monitoring on"
| @@ -31,7 +31,7 @@ public void setup() { | |||
|
|
|||
| @Test | |||
| public void disabledClusterStateTest() { | |||
| setControllerValues(DISABLED_STATE, DISABLED_STATE, DISABLED_STATE, DISABLED_STATE); | |||
| setControllerValues(DISABLED_STATE, DISABLED_STATE, DISABLED_STATE, DISABLED_STATE,DISABLED_STATE ); | |||
There was a problem hiding this comment.
nit: space before DISABLED_STATE.
I see a couple of formatting issues. Can we run ./gradlew spotlessApply
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
Signed-off-by: Surya Sashank Nistala snistala@amazon.com
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.