Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependency license check and removing unused license #183

Merged

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Apr 7, 2022

Signed-off-by: Sagar Upadhyaya sagar.upadhyaya.121@gmail.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#164

Describe the solution you are proposing
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@sgup432 sgup432 requested review from a team, dzane17 and sruti1312 April 7, 2022 20:20
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #183 (78aed68) into main (340f11e) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head 78aed68 differs from pull request most recent head 34fca9b. Consider uploading reports for the commit 34fca9b to get more accurate results

@@             Coverage Diff              @@
##               main     #183      +/-   ##
============================================
- Coverage     71.77%   71.61%   -0.17%     
+ Complexity      356      355       -1     
============================================
  Files            44       44              
  Lines          2459     2459              
  Branches        160      160              
============================================
- Hits           1765     1761       -4     
- Misses          588      591       +3     
- Partials        106      107       +1     
Impacted Files Coverage Δ
...ormanceanalyzer/writer/EventLogQueueProcessor.java 55.95% <0.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 340f11e...34fca9b. Read the comment docs.

@sgup432 sgup432 merged commit 69598fb into opensearch-project:main Apr 8, 2022
@sgup432 sgup432 deleted the enable_dependency_license_check branch April 8, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants