Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update directory names and remove jar for integTest #187

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

sruti1312
Copy link
Contributor

@sruti1312 sruti1312 commented Apr 15, 2022

Signed-off-by: sruti1312 srutiparthiban@gmail.com

Is your feature request related to a problem? Please provide an existing Issue # , or describe.
#167
#156

Describe the solution you are proposing
Standardize file locations for supporting files
Remove .jar dynamic dependencies
Fix formatting issues

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sruti1312 sruti1312 requested a review from a team April 15, 2022 18:45
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
@sruti1312 sruti1312 force-pushed the feature/rename-folder branch 2 times, most recently from 760748e to 5742738 Compare April 15, 2022 19:24
Signed-off-by: sruti1312 <srutiparthiban@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #187 (51a62e6) into main (71d1877) will not change coverage.
The diff coverage is 66.66%.

❗ Current head 51a62e6 differs from pull request most recent head a56c4be. Consider uploading reports for the commit a56c4be to get more accurate results

@@            Coverage Diff            @@
##               main     #187   +/-   ##
=========================================
  Coverage     71.93%   71.93%           
  Complexity      368      368           
=========================================
  Files            44       44           
  Lines          2519     2519           
  Branches        169      169           
=========================================
  Hits           1812     1812           
  Misses          595      595           
  Partials        112      112           
Impacted Files Coverage Δ
...analyzer/config/PerformanceAnalyzerController.java 77.70% <50.00%> (ø)
...dler/PerformanceAnalyzerClusterSettingHandler.java 68.62% <66.66%> (ø)
...config/PerformanceAnalyzerClusterConfigAction.java 88.67% <100.00%> (ø)
...action/config/PerformanceAnalyzerConfigAction.java 93.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d1877...a56c4be. Read the comment docs.

@sruti1312
Copy link
Contributor Author

Building failing due to flaky bwc tests due to cluster formation errors.

@sruti1312 sruti1312 merged commit 3753639 into main Apr 15, 2022
@sruti1312 sruti1312 deleted the feature/rename-folder branch April 15, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants