Catch Notifications Errors on Details Pages (#197)

* add catch statements to notifications get_configs to avoid crashing details pages Signed-off by: David Cui <davidcui@amazon.com> * remove console log statment Signed-off by: David Cui <davidcui@amazon.com>
opensearch-project · Nov 1, 2021 · 677fbab · 677fbab
1 parent 56008de
commit 677fbab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...ds-reports/public/components/main/report_definition_details/report_definition_details.tsx b/...ds-reports/public/components/main/report_definition_details/report_definition_details.tsx
@@ -497,6 +497,9 @@ export function ReportDefinitionDetails(props: { match?: any; setBreadcrumbs?: a
       setChannels(availableChannels);
       return availableChannels;
     })
+    .catch((error: any) => {
+      console.log('error when retrieving notification configs:', error);
+    })
     .then((availableChannels: any) => {
       httpClient
       .get(`../api/reporting/reportDefinitions/${reportDefinitionId}`)

diff --git a/dashboards-reports/public/components/main/report_details/report_details.tsx b/dashboards-reports/public/components/main/report_details/report_details.tsx
@@ -295,6 +295,9 @@ export function ReportDetails(props: { match?: any; setBreadcrumbs?: any; httpCl
       let availableChannels = getAvailableNotificationsChannels(response.config_list);
       return availableChannels;
     })
+    .catch((error: any) => {
+      console.log('error when retrieving notification configs:', error);
+    })
     .then((availableChannels: any) => {
       httpClient
       .get('../api/reporting/reports/' + reportId)