Revert "Replace _opendistro route with _plugins" #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e4e4032.
|
I think we should keep some of the changes that were made, like switching from using strings to using constants and limit this to the routes. Looks good to me to fix the SAML regression until both routes are supported. |
cliu123
approved these changes
Jul 20, 2022
davidlago
approved these changes
Jul 20, 2022
DarshitChanpura
added a commit
that referenced
this pull request
Jul 20, 2022
DarshitChanpura
added a commit
that referenced
this pull request
Jul 20, 2022
DarshitChanpura
added a commit
that referenced
this pull request
Jul 20, 2022
spartan2015
pushed a commit
to spartan2015/security-dashboards-plugin
that referenced
this pull request
Aug 8, 2022
…)" (opensearch-project#1035) This reverts commit e4e4032. Signed-off-by: Vasile Negru <vasile@eosfintek.com>
spartan2015
pushed a commit
to spartan2015/security-dashboards-plugin
that referenced
this pull request
Aug 8, 2022
…roject#895)" (opensearch-project#1035)" This reverts commit c456883362610c61fcc5d54b2974d7a5c6327c1d. Signed-off-by: Vasile Negru <pro@ChooseExcellenc.localdomain> Signed-off-by: Vasile Negru <vasile@eosfintek.com>
spartan2015
pushed a commit
to spartan2015/security-dashboards-plugin
that referenced
this pull request
Aug 8, 2022
…)" (opensearch-project#1035) This reverts commit e4e4032. Signed-off-by: Vasile Negru <pro@ChooseExcellenc.localdomain> Signed-off-by: Vasile Negru <vasile@eosfintek.com>
spartan2015
pushed a commit
to spartan2015/security-dashboards-plugin
that referenced
this pull request
Aug 8, 2022
…roject#895)" (opensearch-project#1035)" This reverts commit c456883362610c61fcc5d54b2974d7a5c6327c1d. Signed-off-by: Vasile Negru <vasile@eosfintek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #895
To fix breaking SAML auth introduced in this. This change will be re-merged once opensearch-project/security#1936 is merged.