#2704 Filter internal users for Service Accounts and add associated API #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page layout not edited yet. Further test needed
samuelcostae
changed the title
|
@samuelcostae Is this PR still being worked on? |
samuelcostae
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
|
Closing this as created a new PR #1502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated UI to make use of new separate Internal/service accounts API endpoints being added to security plugin backend via PR opensearch-project/security#2786
'Internal Users' renamed to 'Internal Accounts' to be in line with 'Service Accounts' as discussed on opensearch-project/security#2842
Category
Enhancement
Why these changes are required?
Improve UX
What is the old behavior before changes and new behavior after changes?
All accounts had to be requested, without filtering Internal/Service
Issues Resolved
#2704
Testing
Unit Testing
Manual check on UI
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.