Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally change where avatar shows up #2082

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

AMoo-Miki
Copy link
Contributor

Description

Reskins the account button and places it in the left nav when updated layout is used:

Also:

  • Fixed a TS error
  • Added aria-* to the button
  • Put a note for contributors to add aria-label and maybe a tooltip

Category

Enhancement

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AMoo-Miki
Copy link
Contributor Author

The unit-test failures are due to OSD's mock of uiSettings incorrectly doesn't mock the start contract. This is fixed in opensearch-project/OpenSearch-Dashboards#7637.

@derek-ho
Copy link
Collaborator

Changes look fine but seems like a unit test is failing

Also update the tests to use good mocks for CoreStart

Signed-off-by: Miki <miki@amazon.com>
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.04%. Comparing base (371495b) to head (044dff1).
Report is 1 commits behind head on main.

Files Patch % Lines
public/apps/account/account-nav-button.tsx 40.00% 0 Missing and 3 partials ⚠️
public/apps/account/account-app.tsx 33.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2082      +/-   ##
==========================================
- Coverage   71.17%   71.04%   -0.13%     
==========================================
  Files          96       96              
  Lines        2598     2604       +6     
  Branches      387      385       -2     
==========================================
+ Hits         1849     1850       +1     
  Misses        649      649              
- Partials      100      105       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DarshitChanpura DarshitChanpura merged commit e3da9b4 into opensearch-project:main Aug 15, 2024
17 of 19 checks passed
@DarshitChanpura DarshitChanpura added the backport 2.x backport to 2.x branch label Aug 15, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 15, 2024
Also update the tests to use good mocks for CoreStart

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit e3da9b4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho added a commit that referenced this pull request Aug 16, 2024
Also update the tests to use good mocks for CoreStart



(cherry picked from commit e3da9b4)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Derek Ho <dxho@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants