Fix a bug where basepath nextUrl is invalid when it should be valid #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2096 +/- ##
=======================================
Coverage 71.39% 71.39%
=======================================
Files 97 97
Lines 2650 2650
Branches 410 403 -7
=======================================
Hits 1892 1892
Misses 642 642
Partials 116 116 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Ho <dxho@amazon.com>
|
Without the change the test fails |
DarshitChanpura
approved these changes
Aug 21, 2024
cwperks
approved these changes
Aug 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
…2096) * Fix a bug where basepath nextUrl is invalid when it should be valid Signed-off-by: Derek Ho <dxho@amazon.com> * Udpate test Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit b1148fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
…2096) * Fix a bug where basepath nextUrl is invalid when it should be valid Signed-off-by: Derek Ho <dxho@amazon.com> * Udpate test Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit b1148fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks
pushed a commit
that referenced
this pull request
Aug 21, 2024
…2096) (#2098) * Fix a bug where basepath nextUrl is invalid when it should be valid * Udpate test --------- (cherry picked from commit b1148fb) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Aug 21, 2024
cwperks
pushed a commit
to cwperks/security-dashboards-plugin
that referenced
this pull request
Aug 22, 2024
…pensearch-project#2096) (opensearch-project#2098) * Fix a bug where basepath nextUrl is invalid when it should be valid * Udpate test --------- (cherry picked from commit b1148fb) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug when OSD is run with a basepath that basepath is an invalid nexturl, when it should be allowed
Category
Bug fix
Why these changes are required?
Fix: #2097
What is the old behavior before changes and new behavior after changes?
now basepath is a valid nexturl
Issues Resolved
Fix: Fix: #2097
Testing
Added a unit test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.