Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rest status for the replication action failure with DLS/FLS #1677

Merged

Conversation

saikaranam-amazon
Copy link
Member

@saikaranam-amazon saikaranam-amazon commented Mar 15, 2022

Fixed rest status for the replication action failure with DLS/FLS
and updated test cases to capture status code

Signed-off-by: Sai Kumar karanas@amazon.com

Description

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Bug fix
  • Why these changes are required? Latest commit changed the status in Add support for DLS Term Lookup Queries #1541
  • What is the old behavior before changes and new behavior after changes? Error code was 403 instead of 500

Issues Resolved

opensearch-project/cross-cluster-replication#340

Is this a backport? If so, please add backport PR # and/or commits #

Testing

unit testing

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

updated test cases to capture status code

Signed-off-by: Sai Kumar <karanas@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1677 (057a070) into main (920701e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1677      +/-   ##
============================================
- Coverage     62.92%   62.88%   -0.04%     
+ Complexity     3259     3258       -1     
============================================
  Files           253      253              
  Lines         18127    18127              
  Branches       3258     3249       -9     
============================================
- Hits          11406    11399       -7     
- Misses         5072     5074       +2     
- Partials       1649     1654       +5     
Impacted Files Coverage Δ
...search/security/configuration/DlsFlsValveImpl.java 58.17% <100.00%> (ø)
...ava/com/amazon/dlic/auth/ldap2/MakeJava9Happy.java 39.13% <0.00%> (-4.35%) ⬇️
.../org/opensearch/security/support/ConfigHelper.java 80.39% <0.00%> (-1.97%) ⬇️
...com/amazon/dlic/auth/ldap2/PrivilegedProvider.java 49.18% <0.00%> (-1.64%) ⬇️
...ic/auth/ldap/backend/LDAPAuthorizationBackend.java 57.57% <0.00%> (-0.38%) ⬇️
...zon/dlic/auth/ldap2/LDAPAuthorizationBackend2.java 28.35% <0.00%> (-0.38%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 45.55% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 920701e...057a070. Read the comment docs.

@saikaranam-amazon saikaranam-amazon marked this pull request as ready for review March 15, 2022 08:15
@saikaranam-amazon saikaranam-amazon requested a review from a team March 15, 2022 08:15
@davidlago davidlago merged commit 1378a29 into opensearch-project:main Mar 15, 2022
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
…opensearch-project#1677)

updated test cases to capture status code

Signed-off-by: Sai Kumar <karanas@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants