Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the step name in CI #1683

Merged

Conversation

cliu123
Copy link
Member

@cliu123 cliu123 commented Mar 16, 2022

Signed-off-by: cliu123 lc12251109@gmail.com

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Maintenance
  • Why these changes are required? The step builds security plugin but does not run tests. The step name is misleading.
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

#1684

Is this a backport? If so, please add backport PR # and/or commits #

Testing

UTs

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: cliu123 <lc12251109@gmail.com>
@cliu123 cliu123 requested a review from a team March 16, 2022 06:54
@peternied peternied merged commit f275fb9 into opensearch-project:main Mar 16, 2022
@cliu123 cliu123 deleted the fix_the_wrong_step_name_in_ci branch March 16, 2022 14:42
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Signed-off-by: cliu123 <lc12251109@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants