Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate BWC tests into parallel workflow #1706

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

peternied
Copy link
Member

Description

BWC tests were being run after normal tests for each JDK. This was
redundant and we can shorten the test runtime by running them in
parallel

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

BWC tests were being run after normal tests for each JDK.  This was
redundant and we can shorten the test runtime by running them in
parallel

Signed-off-by: Peter Nied <petern@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #1706 (86af36c) into main (782b042) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1706   +/-   ##
=========================================
  Coverage     62.85%   62.85%           
  Complexity     3259     3259           
=========================================
  Files           253      253           
  Lines         18082    18082           
  Branches       3242     3242           
=========================================
  Hits          11365    11365           
  Misses         5063     5063           
  Partials       1654     1654           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782b042...86af36c. Read the comment docs.

@peternied peternied added the enhancement New feature or request label Mar 24, 2022
Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied marked this pull request as ready for review March 25, 2022 17:27
@peternied peternied requested a review from a team March 25, 2022 17:27
Copy link
Member

@DarshitChanpura DarshitChanpura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice!

@peternied peternied merged commit 2f02c66 into opensearch-project:main Mar 25, 2022
@peternied peternied deleted the seperate-bwc branch March 25, 2022 21:53
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
BWC tests were being run after normal tests for each JDK.  This was
redundant and we can shorten the test runtime by running them in
parallel

Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants