Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken test due to unsupported EC using JDK-17 #1711

Merged

Conversation

DarshitChanpura
Copy link
Member

Description

Fixes a broken test for testing EC algo which uses an unsupported curve in JDK 17

Issues Resolved

Testing

Gradle test script

Check List

  • New functionality includes testing
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #1711 (0164355) into main (77ddbfd) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1711      +/-   ##
============================================
+ Coverage     62.85%   62.87%   +0.02%     
- Complexity     3258     3261       +3     
============================================
  Files           253      253              
  Lines         18082    18082              
  Branches       3242     3242              
============================================
+ Hits          11365    11369       +4     
+ Misses         5063     5059       -4     
  Partials       1654     1654              
Impacted Files Coverage Δ
...ecurity/configuration/ConfigurationRepository.java 75.27% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ddbfd...0164355. Read the comment docs.

@peternied peternied merged commit 09179d0 into opensearch-project:main Mar 25, 2022
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for sect571k1 as it is no longer supported by Java-17
4 participants