Fix min_doc_count handling when using Document Level Security #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there is a build break, was this change cherry-picked directly the 1.3.1 branch? |
No, it's not cherry-picked from 1.3 branch. |
davidlago
previously approved these changes
Mar 29, 2022
Signed-off-by: cliu123 <lc12251109@gmail.com>
peternied
approved these changes
Mar 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #1714 +/- ##
============================================
+ Coverage 62.86% 62.90% +0.03%
- Complexity 3262 3267 +5
============================================
Files 253 253
Lines 18089 18096 +7
Branches 3243 3246 +3
============================================
+ Hits 11372 11383 +11
+ Misses 5063 5059 -4
Partials 1654 1654
Continue to review full report at Codecov.
|
davidlago
approved these changes
Mar 29, 2022
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…arch-project#1714) Signed-off-by: cliu123 <lc12251109@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cliu123 lc12251109@gmail.com
Description
Fixes an issue in Document Level Security (DLS) by improving how the min_doc_count parameter is handled. The previous behavior returns keys for aggregations with 0 matches when min_doc_count is passed as 0, regardless of whether there are actually 0 matches or matches are not visible due to DLS rules. With this fix, we throw an error message if min_doc_count is passed as 0 and DLS rules are present for that index.
Testing
UTs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.