Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depreciation notice to security tools #1756

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

peternied
Copy link
Member

Description

In order to remove or replace the security tools location we are creating a depreciation notice as part of the tools. There is a link in the tools that link will be pointed to a GitHub issue that will acknowledge the depreciation and also describe the migration path.

Issues Resolved

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied added the documentation For code documentation/ javadocs/ comments / readme etc.. label Apr 8, 2022
@peternied peternied requested a review from a team April 8, 2022 21:13
@peternied peternied self-assigned this Apr 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #1756 (bbc4962) into main (54a920b) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1756      +/-   ##
============================================
- Coverage     60.42%   60.39%   -0.04%     
  Complexity     3197     3197              
============================================
  Files           253      253              
  Lines         18093    18093              
  Branches       3245     3245              
============================================
- Hits          10933    10927       -6     
- Misses         5579     5584       +5     
- Partials       1581     1582       +1     
Impacted Files Coverage Δ
...org/opensearch/security/rest/TenantInfoAction.java 77.94% <0.00%> (-10.30%) ⬇️
...iance/ComplianceIndexingOperationListenerImpl.java 62.31% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54a920b...bbc4962. Read the comment docs.

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied merged commit 74618eb into opensearch-project:main Apr 11, 2022
@peternied peternied deleted the deprecate-tools branch April 11, 2022 20:05
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
* Add deprecation notice to security tools

Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation For code documentation/ javadocs/ comments / readme etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants