Introduce new API _plugins/_security/ssl/certs

[cliu123]

Signed-off-by: cliu123 lc12251109@gmail.com

Description

Introducing _plugins/_security/api/ssl/certs API path to be consistent with OpenSearch API path convention.

• Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Enhancement
• Why these changes are required? Apply consistent API path convention.

Issues Resolved

#1827

Testing

UTs

Check List

• New functionality includes testing
• Commits are signed per the DCO using --signoff

TO-DO

• Create an issue in documentation-website repo to update documentaion once this PR gets merged.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1841 (a9960ad) into main (3d3362a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1841      +/-   ##
============================================
- Coverage     60.87%   60.86%   -0.02%     
+ Complexity     3214     3213       -1     
============================================
  Files           256      256              
  Lines         18006    18006              
  Branches       3209     3209              
============================================
- Hits          10961    10959       -2     
- Misses         5466     5467       +1     
- Partials       1579     1580       +1     

Impacted Files	Coverage Δ
.../security/ssl/rest/SecuritySSLCertsInfoAction.java	61.11% <100.00%> (ø)
...a/org/opensearch/security/tools/SecurityAdmin.java	37.31% <0.00%> (-0.25%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3362a...a9960ad. Read the comment docs.

[peternied]

Thanks for this fix and the updated tests.

While we are doing this, it looks like there are other places where we are not properly supporting both path variants, could build on this or make another PR where we catch all of the missing APIs?

• security/src/main/java/org/opensearch/security/ssl/rest/SecuritySSLReloadCertsAction.java

  Line 52 in 918d998

  new Route(PUT, "_opendistro/_security/api/ssl/{certType}/reloadcerts/")

• security/src/main/java/org/opensearch/security/ssl/rest/SecuritySSLInfoAction.java

  Line 49 in 918d998

  new Route(Method.GET, "/_opendistro/_security/sslinfo")

[opensearch-trigger-bot]

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-1841-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dce58266b0242286ff118f8d1360f7867006ad8a
# Push it to GitHub
git push --set-upstream origin backport/backport-1841-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-1841-to-2.0.