Add default roles for Notifications plugin #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #1847 +/- ##
============================================
+ Coverage 60.86% 60.87% +0.01%
Complexity 3213 3213
============================================
Files 256 256
Lines 18006 18006
Branches 3209 3209
============================================
+ Hits 10959 10961 +2
+ Misses 5467 5466 -1
+ Partials 1580 1579 -1
Continue to review full report at Codecov.
|
cliu123
approved these changes
May 17, 2022
lukkoor
approved these changes
May 18, 2022
praveensameneni
approved these changes
May 18, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 18, 2022
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com> (cherry picked from commit 25eda95)
davidlago
pushed a commit
that referenced
this pull request
May 18, 2022
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mohammad Qureshi 47198598+qreshi@users.noreply.github.com
Description
[Describe what this change achieves]
Adding new full access and read-only roles for the Notifications plugin launching in 2.0.
There is also a
"cluster:admin/opensearch/notifications/feature/publish"permission which is for the legacy Notification publish which only Alerting and ISM use as a fallback to their legacy behavior. This permission has been added to the Alerting and IM full access roles to ensure no disruption in functionality in the fallback case.Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
This PR isn't a backport but it should be backported to the
2.0branch, I don't have permissions to add the label myself to trigger the workflowTesting
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.