-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases with flag do not fail on forbidden enabled. #2154
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2154 +/- ##
============================================
- Coverage 61.05% 61.01% -0.04%
+ Complexity 3269 3265 -4
============================================
Files 259 259
Lines 18337 18337
Branches 3248 3248
============================================
- Hits 11196 11189 -7
- Misses 5555 5560 +5
- Partials 1586 1588 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
src/integrationTest/java/org/opensearch/security/DoNotFailOnForbiddenTests.java
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/DoNotFailOnForbiddenTests.java
Outdated
Show resolved
Hide resolved
src/integrationTest/java/org/opensearch/security/DoNotFailOnForbiddenTests.java
Outdated
Show resolved
Hide resolved
0c7acae
to
7e5adb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks!
@lukasz-soszynski-eliatra Could you please rebase this with main to fetch latest changes? |
I will rebase all PRs created by me which contains conflicts |
7e5adb7
to
3636588
Compare
All PRs have been rebased and conflicts resolved. |
@lukasz-soszynski-eliatra Sorry to ask you to re-base again, but there were recent required checks added to the CI to run the CI on all major platforms. This branch needs to be re-based so it triggers the new Github actions. |
I will rebase all branches related to PRs |
done |
4908f85
Added two missing tests related to mget |
@lukasz-soszynski-eliatra there are some checkstyle violations that failed the build task. And the nebula related failures are known and is being tracked in core |
I will correct it within a minute |
done |
Bwc tests are broken on main build. Tracking issue: #2221 |
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
…st still are green after rebase. Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
b2e34ac
to
e40de27
Compare
Signed-off-by: Lukasz Soszynski lukasz.soszynski@eliatra.com
Description
[Describe what this change achieves]
Integration tests with enabled configuration option "do not fail on forbidden"
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.