Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases with flag do not fail on forbidden enabled. #2154

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

lukasz-soszynski-eliatra
Copy link
Contributor

Signed-off-by: Lukasz Soszynski lukasz.soszynski@eliatra.com

Description

[Describe what this change achieves]

  • Category (Integration test)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Integration tests with enabled configuration option "do not fail on forbidden"

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lukasz-soszynski-eliatra lukasz-soszynski-eliatra requested a review from a team October 11, 2022 14:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #2154 (e40de27) into main (40e2e9c) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2154      +/-   ##
============================================
- Coverage     61.05%   61.01%   -0.04%     
+ Complexity     3269     3265       -4     
============================================
  Files           259      259              
  Lines         18337    18337              
  Branches       3248     3248              
============================================
- Hits          11196    11189       -7     
- Misses         5555     5560       +5     
- Partials       1586     1588       +2     
Impacted Files Coverage Δ
...ecurity/configuration/StaticResourceException.java 0.00% <0.00%> (-25.00%) ⬇️
...nsearch/security/dlic/rest/api/AuditApiAction.java 63.82% <0.00%> (-4.26%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...search/security/transport/SecurityInterceptor.java 75.38% <0.00%> (-0.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

peternied
peternied previously approved these changes Oct 13, 2022
peternied
peternied previously approved these changes Oct 19, 2022
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Oct 21, 2022

@lukasz-soszynski-eliatra Could you please rebase this with main to fetch latest changes?

@lukasz-soszynski-eliatra
Copy link
Contributor Author

I will rebase all PRs created by me which contains conflicts

@lukasz-soszynski-eliatra
Copy link
Contributor Author

All PRs have been rebased and conflicts resolved.

peternied
peternied previously approved these changes Oct 24, 2022
cwperks
cwperks previously approved these changes Nov 2, 2022
@cwperks
Copy link
Member

cwperks commented Nov 2, 2022

@lukasz-soszynski-eliatra Sorry to ask you to re-base again, but there were recent required checks added to the CI to run the CI on all major platforms. This branch needs to be re-based so it triggers the new Github actions.

@lukasz-soszynski-eliatra
Copy link
Contributor Author

lukasz-soszynski-eliatra commented Nov 2, 2022

I will rebase all branches related to PRs

@lukasz-soszynski-eliatra
Copy link
Contributor Author

done

@lukasz-soszynski-eliatra
Copy link
Contributor Author

Added two missing tests related to mget

@DarshitChanpura
Copy link
Member

@lukasz-soszynski-eliatra there are some checkstyle violations that failed the build task. And the nebula related failures are known and is being tracked in core

@lukasz-soszynski-eliatra
Copy link
Contributor Author

I will correct it within a minute

@lukasz-soszynski-eliatra
Copy link
Contributor Author

done

@DarshitChanpura
Copy link
Member

Bwc tests are broken on main build. Tracking issue: #2221

Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
…st still are green after rebase.

Signed-off-by: Lukasz Soszynski <lukasz.soszynski@eliatra.com>
@peternied peternied merged commit 93fe633 into opensearch-project:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants