Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add untriaged label on issues #2297

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

peternied
Copy link
Member

Description

Sometimes when new issues are opened, they don't use the template or are transfered in from another repo, or even are reopened when we ran triage slightly differently. This automation adds the untriaged tag if any of these states are applied.

Coming from

Testing

On my fork of this repo I enabled issues and created a couple and they were automatically tagged on open [1] and reopen [2] by the github action bot for various scenarios [2].

[1] peternied/opensearch-project.github#4
[2] peternied/opensearch-project.github#6
[3] https://github.com/peternied/.github/actions

Documentation

Note; I'm not adding any documentation on this tool because it automates everything that we were doing manually and didn't have documented. Less documentation feels better in my book, but definitely open to other opinions, what do you think the documentation would look like?

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Sometimes when new issues are opened, they don't use the template or are
transfered in from another repo, or even are reopened when we ran triage
slightly differently.  This automation adds the `untriaged` tag if any
of these states are applied.

Coming from
opensearch-project/.github#111

Signed-off-by: Peter Nied <petern@amazon.com>
@peternied peternied requested a review from a team December 5, 2022 18:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #2297 (02d505c) into main (063c1e9) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2297      +/-   ##
============================================
- Coverage     61.02%   60.98%   -0.05%     
+ Complexity     3267     3263       -4     
============================================
  Files           259      259              
  Lines         18337    18337              
  Branches       3248     3248              
============================================
- Hits          11191    11182       -9     
- Misses         5561     5565       +4     
- Partials       1585     1590       +5     
Impacted Files Coverage Δ
...urity/ssl/transport/SecuritySSLNettyTransport.java 62.36% <0.00%> (-4.31%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️
.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java 57.46% <0.00%> (-1.50%) ⬇️
...a/org/opensearch/security/tools/SecurityAdmin.java 36.48% <0.00%> (-0.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@RyanL1997 RyanL1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also create a PR for security-dashboards-repo of applying this automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants