Backport sanity tests to 1.3 #2356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
backport/backport-1958-to-1.3
branch
from
60baaa0
to
83ba6e0
Compare
DarshitChanpura
changed the title
peternied
requested changes
Jan 3, 2023
There was a problem hiding this comment.
Unfortunately we can't just backport this PR, the build.gradle scripts were completely rewritten [1] in 2.0 to fix these issues you are encountering during the build.
Could you see if there a way we can remove the gradle related components of the test so we can minimize build script changes?
|
Lets close out this PR for 1.3 and backport once we have a solution in the 1.X branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #1958 manually
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
- [ ] New functionality includes testing- [ ] New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.