add ml model group system index #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
ylwu-amzn
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford and
reta
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2790 +/- ##
=========================================
Coverage 61.48% 61.48%
+ Complexity 3402 3401 -1
=========================================
Files 266 266
Lines 18865 18865
Branches 3302 3302
=========================================
Hits 11600 11600
Misses 5669 5669
Partials 1596 1596 |
DarshitChanpura
approved these changes
May 25, 2023
RyanL1997
approved these changes
May 25, 2023
|
Thanks, @RyanL1997 Can you also help backport this PR to 2.x and 2.8 branch? I can't add backport labels to this PR |
RyanL1997
added
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 1bb2ef1)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 26, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 1bb2ef1)
RyanL1997
pushed a commit
that referenced
this pull request
May 27, 2023
RyanL1997
pushed a commit
that referenced
this pull request
May 29, 2023
cwperks
pushed a commit
that referenced
this pull request
May 30, 2023
* role.yml changes for lron feature (#2789) (#2792) Signed-off-by: zhichao-aws <zhichaog@amazon.com> (cherry picked from commit a580dfc) Co-authored-by: zhichao-aws <zhichaog@amazon.com> * add ml model group system index (#2790) (#2797) Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 1bb2ef1) Co-authored-by: Yaliang Wu <ylwu@amazon.com> * Rest admin permissions (#2411) Permissions for REST admin user Added granular permissions for all REST API actions in OpenSearch to be individually assigned. Permissions are: - 'restapi:admin/actiongroups' - allow full access to actiongroups - 'restapi:admin/allowlist' - allow full access to allowlist - 'restapi:admin/internalusers'- allow full access to internalusers - 'restapi:admin/nodesdn'- allow full access to nodesdn - 'restapi:admin/roles' - allow full access to roles - 'restapi:admin/rolesmapping' - allow full access to roles mappings - 'restapi:admin/ssl/certs/info' - allow full access to certs info - 'restapi:admin/ssl/certs/reload' - allow full access to certs reload - 'restapi:admin/tenants' - allow full access to tenants Adds tests for these permissions. Signed-off-by: Andrey Pleskach <ples@aiven.io> (cherry picked from commit d676716) * Fixes CI errors Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes HTTP5 imports Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Fixes password related changes in tests Signed-off-by: Darshit Chanpura <dchanp@amazon.com> * Update ActionGroupsApiTest.java Remove unused import * Incorporates jar hell fix Signed-off-by: Darshit Chanpura <dchanp@amazon.com> --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: Yaliang Wu <ylwu@amazon.com> Co-authored-by: Andrey Pleskach <ples@aiven.io> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
RyanL1997
pushed a commit
to RyanL1997/security
that referenced
this pull request
Jun 9, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
RyanL1997
pushed a commit
to RyanL1997/security
that referenced
this pull request
Jun 13, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
This was referenced Jun 13, 2023
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
Signed-off-by: Yaliang Wu <ylwu@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Category (Enhancement)
Why these changes are required?
We are going to add model group in 2.8.
What is the old behavior before changes and new behavior after changes?
Old: we don't have model group, user just create model
New: user need to create model in a model group, and we will use model group to control access.
Issues Resolved
Related issue: opensearch-project/ml-commons#815
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.