Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Backport Service Accounts into 2.x #3639

Merged
merged 10 commits into from
Nov 3, 2023

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Nov 2, 2023

Description

Backport Service Accounts into 2.x

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
    New feature

Issues Resolved

PRs:

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

RyanL1997 and others added 4 commits November 2, 2023 11:20
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #3639 (b5486a4) into 2.x (61bf6f0) will decrease coverage by 0.01%.
Report is 1 commits behind head on 2.x.
The diff coverage is 70.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3639      +/-   ##
============================================
- Coverage     64.78%   64.78%   -0.01%     
- Complexity     3593     3622      +29     
============================================
  Files           282      285       +3     
  Lines         20381    20496     +115     
  Branches       3373     3382       +9     
============================================
+ Hits          13204    13278      +74     
- Misses         5505     5535      +30     
- Partials       1672     1683      +11     
Files Coverage Δ
...nsearch/security/http/OnBehalfOfAuthenticator.java 91.34% <100.00%> (+0.25%) ⬆️
...ecurityconf/impl/SecurityDynamicConfiguration.java 75.72% <100.00%> (+0.48%) ⬆️
...a/org/opensearch/security/user/UserFilterType.java 100.00% <100.00%> (ø)
...ecurity/configuration/ConfigurationRepository.java 73.91% <0.00%> (-2.18%) ⬇️
...c/main/java/org/opensearch/security/user/User.java 71.42% <50.00%> (-0.53%) ⬇️
.../opensearch/security/OpenSearchSecurityPlugin.java 84.44% <60.00%> (-0.26%) ⬇️
...ecurity/authtoken/jwt/ExpiringBearerAuthToken.java 75.00% <75.00%> (ø)
...search/security/identity/SecurityTokenManager.java 95.74% <95.74%> (ø)
...java/org/opensearch/security/user/UserService.java 56.71% <89.47%> (+5.85%) ⬆️
...security/dlic/rest/api/InternalUsersApiAction.java 81.41% <83.33%> (+3.96%) ⬆️
... and 4 more

... and 3 files with indirect coverage changes

Signed-off-by: Ryan Liang <jiallian@amazon.com>
RyanL1997 and others added 3 commits November 2, 2023 12:57
Signed-off-by: Ryan Liang <jiallian@amazon.com>
I was doing some inspection around the OBO feature and noticed some
items to clean up.

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Co-authored-by: Peter Nied <petern@amazon.com>
@RyanL1997
Copy link
Collaborator Author

The failure of the CI is due to the stale of core artifact. The updated artifact of 2.x branch with opensearch-project/OpenSearch#11052 should make the CIs green.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
@DarshitChanpura
Copy link
Member

Error: eckstyle] [ERROR] /home/runner/work/security/security/src/main/java/org/opensearch/security/http/OnBehalfOfAuthenticator.java:51:1: Duplicate import to line 31 - io.jsonwebtoken.JwtParserBuilder. [RedundantImport]

Seems like there were duplicate imports in OnBehalfOfAuthenticator.java

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@DarshitChanpura DarshitChanpura merged commit 01e7158 into opensearch-project:2.x Nov 3, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants