Add new connection parameter tunnelHost to use with tunnel cunnection.
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
commented
Jun 3, 2023
src/main/java/org/opensearch/jdbc/config/TunnelHostConnectionProperty.java
Outdated
Show resolved
Hide resolved
…ixes. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
MaxKsyunz
as code owners
acarbonetto
approved these changes
Jun 6, 2023
src/main/java/org/opensearch/jdbc/config/TunnelHostConnectionProperty.java
Show resolved
Hide resolved
acarbonetto
approved these changes
Jun 15, 2023
GumpacG
reviewed
Jun 16, 2023
| @@ -105,15 +106,15 @@ Code samples to open a connection for some typical scenarios are given below: | |||
| import java.sql.Connection; | |||
| import java.sql.DriverManager; | |||
| import java.sql.Statement; | |||
| . | |||
There was a problem hiding this comment.
Do you know why there were so many periods placed throughout the old code? Would they not break the code that's there or is there something syntax related with them that I don't know about?
matthewryanwells
approved these changes
Jun 16, 2023
Co-authored-by: Matthew Wells <matthew.wells@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
GumpacG
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to opensearch-project/sql-odbc#42 this PR adds a new connection config parameter
tunnelHostto be set when tunnel is used.TODOs
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.