Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken forum link #694

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

Yury-Fridlyand
Copy link
Collaborator

Signed-off-by: Yury Fridlyand yuryf@bitquilltech.com

Description

Re-applying (cherry-pick) c523102 made by @dai-chen. Should be merged into all PRs opened now.

Issues Resolved

Fixes link checker failures.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chen Dai <daichen@amazon.com>
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner July 15, 2022 17:55
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #694 (5c5c0aa) into main (8d9b459) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #694   +/-   ##
=========================================
  Coverage     94.74%   94.74%           
  Complexity     2857     2857           
=========================================
  Files           283      283           
  Lines          7676     7676           
  Branches        561      561           
=========================================
  Hits           7273     7273           
  Misses          349      349           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 97.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9b459...5c5c0aa. Read the comment docs.

@joshuali925 joshuali925 merged commit 3f545f2 into opensearch-project:main Jul 15, 2022
@Yury-Fridlyand Yury-Fridlyand deleted the integ-fix-forum-link branch July 15, 2022 18:41
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2022
Signed-off-by: Chen Dai <daichen@amazon.com>

Co-authored-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit 3f545f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants