Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BWC tests #721

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Remove BWC tests #721

merged 3 commits into from
Aug 4, 2022

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Aug 3, 2022 •
edited
Loading

Remove backward compatibility (BWC) tests with OpenDistro from GitHub Actions (GHA), because OpenDistro was archived and not available anymore for testing.
https://opendistro.github.io/for-elasticsearch/blog/2022/08/Open-Distro-is-archived/

Signed-off-by: Yury Fridlyand yuryf@bitquilltech.com

Description

Issues Resolved

Failing GHA

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yury-Fridlyand
Removed backward compatibility (BWC) tests, because OpenDistro was …
4653e82 
…archived and not available anymore for testing.

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@Yury-Fridlyand
Merge pull request #97 from Bit-Quill/dev-remove-bwc
99d7fcd 
Remove backward compatibility (BWC) tests
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner August 3, 2022 16:49
@joshuali925
Copy link
Member

joshuali925 commented Aug 3, 2022 •
edited
Loading

BWC test will still be needed for opensearch? like OS1.0 to OS2.0. possible to keep the framework but only remove ODFE related tests?

acarbonetto
acarbonetto previously approved these changes Aug 3, 2022
View reviewed changes
@Yury-Fridlyand
Recover BWC test suite, but keep it disabled.
58993e1 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@dai-chen
Copy link
Collaborator

dai-chen commented Aug 4, 2022

Approving to unblock other failed PR for now. But not sure if we should do this the other way around (un-archive the ODFE repo). Because I recall we need to patch ODFE sometimes, archived repo blocks code merge.

dai-chen
dai-chen approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

joshuali925
joshuali925 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not needed to change script permission but ok

@joshuali925 joshuali925 merged commit d26cde3 into opensearch-project:main Aug 4, 2022
@joshuali925
Copy link
Member

Approving to unblock other failed PR for now. But not sure if we should do this the other way around (un-archive the ODFE repo). Because I recall we need to patch ODFE sometimes, archived repo blocks code merge.

we don't need to patch ODFE anymore as it reached EOL, but we should remove ODFE related BWC tests while keep BWC framework for OpenSearch

@Yury-Fridlyand Yury-Fridlyand deleted the integ-remove-bwc branch August 4, 2022 18:14
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Aug 5, 2022
@Yury-Fridlyand @MitchellGale
Remove BWC tests (opensearch-project#721)
5a6e779 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
@dblock
Copy link
Member

dblock commented Aug 6, 2022

+1 to @joshuali925, removing bcw tests seems like an undesirable effect

If you agee @Yury-Fridlyand, care to open an issue to restore the bcw tests against supported versions of OpenSearch?

@Yury-Fridlyand
Copy link
Collaborator Author

Sure. We can start testing upgrade scenario 1.x -> 2.x.

@dblock dblock mentioned this pull request Aug 7, 2022
Closed
@dblock
Copy link
Member

dblock commented Aug 7, 2022

I opened #733

dai-chen pushed a commit to dai-chen/sql-1 that referenced this pull request Aug 15, 2022
@Yury-Fridlyand @dai-chen
Remove BWC tests (opensearch-project#721)
38f7b69 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
dai-chen pushed a commit to dai-chen/sql-1 that referenced this pull request Aug 15, 2022
@Yury-Fridlyand @dai-chen
Remove BWC tests (opensearch-project#721)
b215c4c 
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
dai-chen added a commit that referenced this pull request Aug 16, 2022
@dai-chen @Yury-Fridlyand
Backport Spring and jackson-databind version bump to 2.x (#759)
7a4145e 
* Backport Spring and jackson version bump

Signed-off-by: Chen Dai <daichen@amazon.com>

* Remove BWC tests (#721)

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Chen Dai <daichen@amazon.com>

Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com>
penghuo pushed a commit to penghuo/os-sql that referenced this pull request Aug 17, 2022
@dai-chen @Yury-Fridlyand @penghuo
Backport Spring and jackson-databind version bump to 2.x (opensearch-…
4417b86 
…project#759)

* Backport Spring and jackson version bump

Signed-off-by: Chen Dai <daichen@amazon.com>

* Remove BWC tests (opensearch-project#721)

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Chen Dai <daichen@amazon.com>

Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com>
penghuo added a commit that referenced this pull request Aug 17, 2022
@penghuo @Yury-Fridlyand
Backport Spring and jackson-databind version bump to 2.x (#759) (#775)
808813d 
* Backport Spring and jackson version bump

Signed-off-by: Chen Dai <daichen@amazon.com>

* Remove BWC tests (#721)

Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Signed-off-by: Chen Dai <daichen@amazon.com>

Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Yury Fridlyand <yuryf@bitquilltech.com>
Co-authored-by: Yury-Fridlyand <yuryf@bitquilltech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@dai-chen dai-chen dai-chen approved these changes

@acarbonetto acarbonetto acarbonetto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yury-Fridlyand @joshuali925 @dai-chen @dblock @acarbonetto