Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Test against opensearch 1.2.x #46

Closed
wants to merge 1 commit into from

Conversation

phillbaker
Copy link
Collaborator

Description

Moves testing support forward to 1.2.x, see #44

Issues Resolved

Part of 2.x support

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Phillip Baker <phillbaker@retrodict.com>
@prudhvigodithi
Copy link
Collaborator

Hey @phillbaker this should be merged to 1.x branch and also should we change image version to 1.3? as that is the supported 1.x version.
Also this entire check - os-major-version: "1-opensearch" should be excluded from main and should remain only in 1.x branch. This was the main can be fast forward and deal with only upcoming 2.x version releases.
Please check https://github.com/opensearch-project/terraform-provider-opensearch#version-and-branching and add your thoughts.
@bbarani @peterzhuamazon

@phillbaker
Copy link
Collaborator Author

See my comment in #44 (comment), I'll have a follow up PR for 1.3.x support coming next. The intent is to break up the work into chunks, although this one didn't require any specific changes.

@prudhvigodithi
Copy link
Collaborator

Closing this PR as the main branch CI checks are tested with 2.x versions, related PR.
@phillbaker please feel free to re-open if required.
@bbarani @peterzhuamazon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants