Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-1063: remove kubebuilder validation for placementGroupPartition #1942

Closed
wants to merge 1 commit into from

Conversation

chiragkyal
Copy link
Member

@chiragkyal chiragkyal commented Jul 1, 2024

As per #1897 (comment)
Kubebuilder validations won't work on this particular API, we will need to add them in webhook validation.

Signed-off-by: chiragkyal <ckyal@redhat.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 1, 2024

@chiragkyal: This pull request references CFE-1063 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 1, 2024
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

Hello @chiragkyal! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2024
@openshift-ci openshift-ci bot requested review from JoelSpeed and mandre July 1, 2024 11:39
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiragkyal
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 1, 2024

@chiragkyal: This pull request references CFE-1063 which is a valid jira issue.

In response to this:

As per #1897 (comment)
Kubebuilder validations won't work on this particular API, we will need to add them in webhook validation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Contributor

Even though the validations do not actually work here, I'd prefer we have them in the API to indicate the validations that we are making via the webhooks. This is a strange edge case but it's better to have that indication IMO, for consistency with other APIs
/close

@openshift-ci openshift-ci bot closed this Jul 1, 2024
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

@JoelSpeed: Closed this PR.

In response to this:

Even though the validations do not actually work here, I'd prefer we have them in the API to indicate the validations that we are making via the webhooks. This is a strange edge case but it's better to have that indication IMO, for consistency with other APIs
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chiragkyal chiragkyal deleted the remove-validation branch July 1, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants